Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform refactor: use one variables.tf for ALL venues, component version info should only be in one place #714

Open
philipjyoon opened this issue Jan 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request needs triage Issue that requires triage

Comments

@philipjyoon
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

No response

Describe the feature request

variables.tf
Currently there are at least two variables.tf being used in different deployment scenarios. e2e variables.tf is used in e2e testing and int/pst/ops/etc. modules/common/variables.tf seems to be used in dev deployments. We should have exactly one variables.tf file used in all venue deployments.

We have variables like hysds version, pcm version, etc. We should also have these in one place in terraform. Right now they are in several places.

@philipjyoon philipjyoon added enhancement New feature or request needs triage Issue that requires triage labels Jan 10, 2024
@philipjyoon philipjyoon self-assigned this Apr 18, 2024
@philipjyoon
Copy link
Contributor Author

There is also a variables.tf in dev folder. This file surely is not necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue that requires triage
Projects
None yet
Development

No branches or pull requests

1 participant