Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Add DSWx-S1 test cases into integration test #705

Open
hhlee445 opened this issue Dec 21, 2023 · 5 comments
Open

[New Feature]: Add DSWx-S1 test cases into integration test #705

hhlee445 opened this issue Dec 21, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request needs triage Issue that requires triage pcm.r03 PCM Release 3

Comments

@hhlee445
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

No - I haven't considered

Related problems

No response

Describe the feature request

An unit test of RTC data retrieval and DSWx-S1 PGE execution needs to be added into the integration test.

@hhlee445 hhlee445 added enhancement New feature or request needs triage Issue that requires triage pcm.r03 PCM Release 3 labels Dec 21, 2023
@riverma
Copy link
Collaborator

riverma commented Jan 31, 2024

Hi @hhlee445, as discussed I'd like to propose (based on conversations with @chrisjrd and @collinss-jpl):

  1. Implement these tests into the existing test_integration.py script. We should be checking for metadata of the finished jobs to ensure they match the expected mgrs_tile_set ids listed (to ensure the right jobs were kicked off).
  2. Edge case tests for DSWx-S1 defined here need to be run nightly / automatically either:
    1. Within the test_integration.py script (which runs every day)
    2. As part of @collinss-jpl 's nightly tests of the PGE
  3. Resolve [New Feature]: MGRS Tile Set DB Integration Tests #725 so that we’re also testing our assumptions for how the MGRS DB is structured
  4. Add unit tests for @chrisjrd's DSWx-S1 evaluator script to account for a given set of bursts matching multiple mgrs_set_ids (as well as also checking existing 100%, 0% and partial coverage constraints)

@riverma
Copy link
Collaborator

riverma commented Jan 31, 2024

See also this ticket regarding running unit tests automatically as well: #726

chrisjrd added a commit that referenced this issue Feb 28, 2024
chrisjrd added a commit that referenced this issue Feb 29, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 1, 2024
chrisjrd added a commit that referenced this issue Mar 8, 2024
chrisjrd added a commit that referenced this issue Mar 8, 2024
NOTE: still needs to be tested. but adding framework

Refs #705
chrisjrd added a commit that referenced this issue Mar 11, 2024
chrisjrd added a commit that referenced this issue Mar 12, 2024
chrisjrd added a commit that referenced this issue Mar 12, 2024
@hhlee445 hhlee445 closed this as completed Apr 9, 2024
@hhlee445 hhlee445 reopened this Apr 16, 2024
@riverma
Copy link
Collaborator

riverma commented Apr 16, 2024

Hey @hhlee445 - just wanted to bring in @philipjyoon and his DISP-S1 testing framework which he mentioned could be repurposed for DSWx-S1. This framework has a really easy to modify json testing scenario file approach that separates the test details from the underlying execution of the test. Down-the-line it might be a good idea converge on a single integration / system testing framework. Let's chat more.

@hhlee445
Copy link
Contributor Author

PCM team discussed about DISP-S1 testing framework and @chrisjrd is looking at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue that requires triage pcm.r03 PCM Release 3
Projects
None yet
Development

No branches or pull requests

3 participants