New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gauge] Value range and limit indicators are broken #6593
Comments
…disable if value is invalid
Note that this is a broken validation mechansim |
Hey all, I looked into these issues and was able to fix them. It's not allowing me to push to origin though, permission denied error. |
Awesome, thanks for looking into this. Please open a PR so we can review your changes. Also, you'll need to submit a CLA if you have not done so already. An approved CLA is needed before we can merge your code. We can still review in the meantime while we wait for that. |
fix: valid indicators not updating properly for Gauge plugin limits refactor: enforce limitLow to be less than or equal to limitHigh
fix: OK button not properly disabling when data is invalid note: (implementation works around the broken validation mechanism)
Summary
When a user manually enters high/low limits, the validity indicators (the red x or green check) that used to work, do not anymore. They stay showing invalid, regardless of whether the values a user inputs are valid or not. Additionally, when a user does enter an invalid limit, the OK button used to be disabled, disallowing users to save the Gauge until a valid value was inputted. This doesn't happen anymore– instead, users can save the object with invalid limits.
Notice in the picture below: The high limit of 90 IS valid if the maximum value is 100. However, the indicator shows it as invalid.
Additionally, the low limit of -20 IS NOT valid if the minimum value is 0. The indicator shows it as invalid as well. Now notice that the OK button is not disabled, and allows for a user to save the changes.
Expected vs Current Behavior
Steps to Reproduce
Environment
Impact Check List
Additional Information
The text was updated successfully, but these errors were encountered: