Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example index.html should not be included in npm distributable #7680

Open
ozyx opened this issue Apr 10, 2024 · 2 comments · May be fixed by #7699
Open

Example index.html should not be included in npm distributable #7680

ozyx opened this issue Apr 10, 2024 · 2 comments · May be fixed by #7699
Assignees
@ozyx
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:4.0.0

Comments

@ozyx
Copy link
Member

ozyx commented Apr 10, 2024

Summary

We currently include our example index.html in our distributable (dist/index.html). This may be confusing for consumers of Open MCT as it's really only meant to be used as an example while developing. We should remove this from the dist .
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Apr 10, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Apr 10, 2024
@ozyx ozyx self-assigned this Apr 10, 2024
@evenstensberg
Copy link
Contributor

I can fix this if needed

@ozyx
Copy link
Member Author

ozyx commented Apr 16, 2024

@evenstensberg please do! :)

@evenstensberg evenstensberg linked a pull request Apr 17, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(publishing): no index.html on npm pack evenstensberg/openmct
2 participants
@ozyx @evenstensberg