Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Conductor calendar popup appears cut off #7594

Closed
4 of 7 tasks
akhenry opened this issue Mar 15, 2024 · 2 comments · May be fixed by #7662
Closed
4 of 7 tasks

Time Conductor calendar popup appears cut off #7594

akhenry opened this issue Mar 15, 2024 · 2 comments · May be fixed by #7662
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@akhenry
Copy link
Contributor

akhenry commented Mar 15, 2024 •
edited

Summary

The time conductor calendar appears to be rendering too far to the left of the conductor itself, causing it to appear truncated. See screenshot
Screenshot 2024-03-15 at 8 23 02 AM

Steps to Reproduce

  1. Put time conductor in fix time mode
  2. Click on the calendar icon next to the start bounds input
  3. Observe that the calendar popup appears offset to the left of the screen

Environment

  • Open MCT Version: 4.0.0-next
  • Deployment Type: Testathon, mini-sim

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@akhenry akhenry added this to the Target:4.0.0 milestone Mar 15, 2024
rukmini-bose added a commit that referenced this issue Mar 15, 2024
@rukmini-bose
Fix #7594
6f4bf97
@rukmini-bose rukmini-bose mentioned this issue Mar 15, 2024
Merged
14 tasks
@rukmini-bose rukmini-bose self-assigned this Mar 15, 2024
@unlikelyzero unlikelyzero added the needs:test instructions Missing testing notes label Mar 18, 2024
@akhenry akhenry closed this as completed Mar 18, 2024
@rukmini-bose
Copy link
Contributor

Testing Instructions:

  1. Navigate to Open MCT and resize your window pane so it's pretty small.
  2. Change the TC to Fixed Time and click on the calendar that changes the start time.
  3. Verify that the Calendar opens to the right and is NOT being cut off.
  4. Click on the calendar that changes the end time.
  5. Verify that the Calendar opens up to the left and is NOT being cut off.
  6. Now navigate to an Open MCT object that has an Independent Time Conductor (Plot, Time List, etc).
  7. Repeat steps 2 and 3 and verify that the calendar opens downwards and left/right in a way that the calendar is not being cut off.

@ozyx ozyx removed the needs:test instructions Missing testing notes label Mar 19, 2024
@akhenry akhenry self-assigned this Mar 19, 2024
@akhenry
Copy link
Contributor Author

akhenry commented Mar 20, 2024

Verified fixed, nice work

@akhenry akhenry added the verified Tested or intentionally closed label Mar 20, 2024
@akhenry akhenry removed their assignment Mar 20, 2024
This was referenced Apr 1, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

[Mobile] Fix for ITC calendar being cutoff nasa/openmct
5 participants
@charlesh88 @akhenry @ozyx @unlikelyzero @rukmini-bose