Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotating image notebook snapshots is broken #7552

Closed
2 of 7 tasks
ozyx opened this issue Mar 5, 2024 · 3 comments · Fixed by #7555
Closed
2 of 7 tasks

Annotating image notebook snapshots is broken #7552

ozyx opened this issue Mar 5, 2024 · 3 comments · Fixed by #7555
Labels
severity:blocker type:bug verified Tested or intentionally closed
Milestone
Target:4.0.0

Comments

@ozyx
Copy link
Member

ozyx commented Mar 5, 2024

Summary

Opening an image snapshot and annotating it causes Open MCT to crash.

Expected vs Current Behavior

Should be able to annotate image snapshots without failure

Steps to Reproduce

  1. Create Example Imagery
  2. Open an Image
  3. Select Snapshot > Create a Notebook Snapshot
  4. Open the Snapshots menu from the Snapshot indicator
  5. Click the Image
  6. In the context menu, click "annotate"
  7. No image, errors in console

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@ozyx ozyx added the type:bug label Mar 5, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 5, 2024
@ozyx ozyx self-assigned this Mar 5, 2024
@ozyx ozyx mentioned this issue Mar 5, 2024
Merged
15 tasks
jvigliotta pushed a commit that referenced this issue Mar 13, 2024
@ozyx @unlikelyzero
fix(#7552): Fix notebook snapshot image annotations (#7555)
faed27c 
* fix: painterro import

* test(snapshotAnnotation): add minimal e2e test

* chore: add e2e test annotation

* fix: notebook snapshot test

* refactor: put `v-else` on template

* small changes to the test and a visual one

* additional a11y

* fix: html structure

* test(e2e): fix notebook snapshot tests

* Update documentation for file download and JSON testing

* Update stubs and add jpg/png export

* refactor(TimelistComponent): tidy up

---------

Co-authored-by: John Hill <john.c.hill@nasa.gov>
@ozyx
Copy link
Member Author

ozyx commented Mar 14, 2024

Testing Instructions

  • Try taking snapshots of various objects and annotating them
  • Verify no errors in console and that annotating works, persists correctly, exports, etc

@rukmini-bose
Copy link
Contributor

Testathon 3/14/2024, Cannot test with Example Imagery due to CORS issue

@rukmini-bose
Copy link
Contributor

rukmini-bose commented Mar 19, 2024 •
edited

Testathon 3/19/2024– annotations work but there's a separate issue of where Snapshots are not capturing certain objects properly. I created a new issue for this: #7622

However, I tested and verified that snapshots and annotations work properly for imagery. Exporting after annotating works too

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:blocker type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging a pull request may close this issue.

fix(#7552): Fix notebook snapshot image annotations nasa/openmct
3 participants
@ozyx @unlikelyzero @rukmini-bose