Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow, alignment and padding in text and button elements causing problems #7540

Open
3 of 7 tasks
charlesh88 opened this issue Mar 1, 2024 · 1 comment · May be fixed by #7541
Open
3 of 7 tasks

Overflow, alignment and padding in text and button elements causing problems #7540

charlesh88 opened this issue Mar 1, 2024 · 1 comment · May be fixed by #7541
Assignees
Labels
bug:visual Visual problem. Not a functional issue severity:trivial type:bug

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Mar 1, 2024

Problem

Many users trying to make the best use of available pixel real estate are using Condition Widgets and Hyperlinks at a very small size. When the widget is sized below the requirements of content and padding, scrollbars appear. They are additionally mixing these elements with text drawing objects in Display Layouts. Text is also not aligned the same between Condition Widgets, Hyperlinks (both links and buttons) and Display Layout text drawing objects. Hyperlink links don't expand to fill their containers when their frames are hidden, but should. This is visually undesirable and hampers the construction of efficient and aligned displays.

Screenshot 2024-03-01 at 5 10 17 PM

Solution

Normalize padding, alignment and overflow handling for widgets, Hyperlinks and text drawing objects.

Screenshot 2024-03-01 at 5 10 36 PM

Steps to Reproduce

  1. Make a Condition Widget and Hyperlinks, both link and button types.
  2. Make a SWG if needed for a telemetry source.
  3. Add all items to a Display Layout with a grid with a small Y dimension, something 10, 3.
  4. Add a text drawing object to the layout.
  5. Size elements such that their height is a little more than their text's height. Observe: scrollbars in the widget and Hyperlink link should be visible.
  6. Align non-button elements such that their left edges are aligned. Note that their text does not all align along a vertical axis.

Environment

  • Open MCT Version: 4.0.0
  • Deployment Type: any
  • OS: all
  • Browser: legion

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@charlesh88 charlesh88 self-assigned this Mar 1, 2024
@charlesh88 charlesh88 added this to the Target:4.0.0 milestone Mar 1, 2024
charlesh88 added a commit that referenced this issue Mar 1, 2024
- Adds `overflow: hidden` to Condition Widget label and
alphanumeric wrappers.
@charlesh88 charlesh88 linked a pull request Mar 1, 2024 that will close this issue
15 tasks
@charlesh88
Copy link
Contributor Author

Testing Notes

JSON import file here that provides the needed elements, in a Display Layout: Open MCT Text and Button Overflow and Padding.json.zip

  1. Import the attached Display Layout.
  2. Browse to the layout.
  3. Verify that if looks like the image below:

Screenshot 2024-03-01 at 5 10 36 PM

@charlesh88 charlesh88 changed the title Scrollbars appearing in Condition Widget when very small Overflow, alignment and padding in text and button elements causing problems Mar 2, 2024
charlesh88 added a commit that referenced this issue Mar 2, 2024
- Adds `overflow: hidden` to Condition Widget label and
alphanumeric wrappers.
@unlikelyzero unlikelyzero added severity:trivial bug:visual Visual problem. Not a functional issue labels Mar 3, 2024
@akhenry akhenry removed this from the Target:4.0.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:visual Visual problem. Not a functional issue severity:trivial type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants