Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprime-gds: default file downlink directory can overwrite files #2657

Open
timcanham opened this issue Apr 3, 2024 · 1 comment
Open

fprime-gds: default file downlink directory can overwrite files #2657

timcanham opened this issue Apr 3, 2024 · 1 comment
Labels
enhancement F´ GDS Issues pertaining to the F´ GDS

Comments

@timcanham
Copy link
Collaborator

F´ Version v3.4.3
Affected Component n/a

Feature Description

Have GDS created a time-tag directory for file downlinks.

Make the default be logs/<time tag>/fprime-downlink to match telemetry and events.

Also, make a separate argument for uplink and downlink. It makes sense to automatically separate downlinked files, but uplink may wish to be in a common store.

Rationale

The default /tmp/username (or even overridden with --file-storage-directory) directory for file downlinks can cause new instances to overwrite older files, or cause parallel instances to clobber each other.

@thomas-bc thomas-bc added the F´ GDS Issues pertaining to the F´ GDS label Apr 3, 2024
@Joshua-Anderson
Copy link
Collaborator

Also discussed in #2658 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement F´ GDS Issues pertaining to the F´ GDS
Projects
None yet
Development

No branches or pull requests

3 participants