PDU length bits vs bytes

[martinerikwerner-aac]

CCSDS 355.1-B-1 indicates that the length field of EP PDUs should be the length of the PDU data field in bits:

5.3.2.3.1 The Extended Procedures Data Field Length shall signal the length of the Extended Procedures PDU Data Field in bits.

This is also indicated by the declaration in:

CryptoLib/include/crypto_structs.h

Line 107 in ef64d8d

uint16_t pdu_len : 16; // EP Data Field Length - BITS

However, the use of this field seems to treat is as the number of octets, for example:

CryptoLib/src/core/crypto_mc.c

Lines 169 to 171 in ef64d8d

	sdls_frame.pdu.pdu_len = 1;
	sdls_frame.hdr.pkt_length = sdls_frame.pdu.pdu_len + 9;
	count = Crypto_Prep_Reply(ingest, 128);

CryptoLib/src/core/crypto.c

Lines 270 to 271 in ef64d8d

	ingest[count++] = (sdls_frame.pdu.pdu_len & 0xFF00) >> 8;
	ingest[count++] = (sdls_frame.pdu.pdu_len & 0x00FF);

[rjbrown2]

Hi martinerikwerner-aac. Thanks for bringing this to our attention. We have not yet worked on Extended procedures at this time - so the tests are currently broken. This is on our short-term roadmap, and we will leave this issue open for tracking and completion. Thanks again!