Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support elastic/beats v6 and/or v7 #7

Open
ecc256 opened this issue Jul 29, 2018 · 5 comments
Open

Support elastic/beats v6 and/or v7 #7

ecc256 opened this issue Jul 29, 2018 · 5 comments

Comments

@ecc256
Copy link

ecc256 commented Jul 29, 2018

Guys,
Any plans to make it compatible with elastic/beats version 7.0 (alpha) or latest 6.* at least?

@phillbaker
Copy link
Contributor

Hi @ecc256, thanks for opening the issue. We will likely upgrade this beat, but can't give a timeline. If you'd like to submit a PR, we'd happily review and merge.

My guess is that based on the breaking changes list, it wouldn't be too bad. We'd need to update the dependencies:

https://github.com/narmitech/cloudwatchmetricbeat/blob/a1162cf17f4b3f61d0f6413518fd4a28435d7234/glide.yaml#L4

and potentially make some code changes.

@ecc256
Copy link
Author

ecc256 commented Jul 30, 2018

Phillip,
I did it already.
I straggle with getting stats for 2 or more dimensions at once in single GetMetricStatistics() call now.
According to docs it should be possible, but it returns data points to the last dimension only.
Same exact behaviors from go and aws cli script.

aws cloudwatch get-metric-statistics --metric-name CPUUtilization ^
  --start-time 2018-07-29T00:00:00Z ^
  --end-time   2018-07-29T06:00:00Z ^
  --period 3600 --namespace AWS/EC2 ^
  --statistics Average ^
  --dimensions Name=InstanceId,Value=i-abcd Name=InstanceId,Value=i-ifgh

returns data points for InstanceId=i-ifgh only
I assume it’s not possible as there is no way to tell, what dimension a data point belongs to?

@phillbaker
Copy link
Contributor

Ah, would you mind opening a separate issue for that? We've had that feature request internally as well.

As well, would you mind forking this repo and pushing your work to that fork so that we can take a look?

@ecc256
Copy link
Author

ecc256 commented Jul 30, 2018

Ah, would you mind opening a separate issue for that? We've had that feature request internally as well.

Will do.

As well, would you mind forking this repo and pushing your work to that fork so that we can take a look?

It’s nothing to push as of now.
I’m testing it from standalone go program, not related to beats.

Could you check if aws cli command I posted returns stats for 2 dimensions, please?
Want to make sure, it’s not just me...

@phillbaker phillbaker changed the title Feature request...? Support elastic/beats v6 and/or v7 Jul 30, 2018
@jasonlang80
Copy link
Contributor

@ecc256 if you have a branch or fork where you are already working on the v6 of this beat please let me know. I will try and clear some time to help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants