Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quotation when the path contain blank #42

Open
yufree opened this issue Nov 5, 2018 · 1 comment
Open

Use quotation when the path contain blank #42

yufree opened this issue Nov 5, 2018 · 1 comment

Comments

@yufree
Copy link

yufree commented Nov 5, 2018

When the path contains blank, the render_docker would fail. I suggested to add a test for blank in path. When the path contains blank, use extra quotation for the path of Dockerfile.

For example:

$docker_build_cmd
[1] "docker build --no-cache=false --rm=true  /Users/hehe/Box Sync/xcmsrocker/ISMMS"

This command would fail since the blank in the path would break the build and the right one should be

$docker_build_cmd
[1] "docker build --no-cache=false --rm=true  "/Users/hehe/Box Sync/xcmsrocker/ISMMS""

Also, I am curious about why you use \" \" for the tag and a default tag with lastest might be fine in most cases.

ps. I know blank in path is not cool and I have no idea why Box use such path...

@nanxstats
Copy link
Owner

@yufree -good catch! Let me try to find some time this week and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants