Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we check for "Revision" in vocabularies.managers? #55

Open
2 tasks
mortenwh opened this issue Feb 6, 2019 · 0 comments · May be fixed by #156
Open
2 tasks

Why do we check for "Revision" in vocabularies.managers? #55

mortenwh opened this issue Feb 6, 2019 · 0 comments · May be fixed by #156
Assignees
@azamifard
Labels
enhancement question

Comments

@mortenwh
Copy link
Contributor

mortenwh commented Feb 6, 2019

Revision does not seem to exist in the dict keys and the situations in geospaas.vocabularies.managers are not tested.

if 'Revision' in platform.keys():
    continue

I.e., the second line is not tested.

  • Check if this is really needed

  • Add unit tests for these situations
mortenwh added a commit that referenced this issue Feb 6, 2019
@mortenwh
#1: almost full test coverage of geospaas.vocabularies.managers, exce…
ada572d 
…pt as described in #55
azamifard pushed a commit that referenced this issue Mar 4, 2021
#55 converting strings into number in order to install them correctly…
c0fa8c5 
… as fixture
azamifard pushed a commit that referenced this issue Mar 4, 2021
#55 remove update_vocabularies_related tests
daf8458
azamifard pushed a commit that referenced this issue Mar 4, 2021
#55 remove update vocabularies functions from manager of vocabulary
473ecc7
@azamifard azamifard linked a pull request Mar 4, 2021 that will close this issue
Open
@aperrin66 aperrin66 linked a pull request Dec 27, 2021 that will close this issue
Issue55 double checking the revision #156
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azamifard azamifard

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue55 double checking the revision nansencenter/django-geo-spaas
2 participants
@mortenwh @azamifard