Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support list, dict, ndarray and other non-trivial params da_method #53

Open
2 tasks
patnr opened this issue Feb 28, 2021 · 1 comment
Open
2 tasks

Support list, dict, ndarray and other non-trivial params da_method #53

patnr opened this issue Feb 28, 2021 · 1 comment
Assignees
@patnr
Labels
enhancement
Projects
v2

Comments

@patnr
Copy link
Collaborator

patnr commented Feb 28, 2021 •
edited

For example, Var3D(B=B) should work, where B is an ndarray background matrix.

  • The problem is largely that == comparison with ndarray fails in split_attrs. I'm not sure about other non-trivial types.
  • When printing xpLists multiline attributes will be an issue. I suppose one should insert the id in that case.
@patnr patnr added this to To do in v2 via automation Feb 28, 2021
patnr added a commit that referenced this issue Mar 15, 2021
@patnr
Support ndarray B in 3D-Var (ref #53 & email by Burba Mareike)
28c2d16
@patnr patnr self-assigned this Mar 15, 2021
@patnr
Copy link
Collaborator Author

patnr commented Mar 15, 2021 •
edited

The above commit is a hotfix. Improvements would still be good. See inline TODOs. Furthermore, I believe xpSpace might still be incompatible with ndarray params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patnr patnr

Labels
enhancement
Projects
v2
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patnr