Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM models: in dynamic_binary_number calculation, use a different interpolation variable besides redshift #80

Open
lzkelley opened this issue Jun 22, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lzkelley
Copy link
Member

Invalid bins have z=-1. Interpolating between these values and valid bins thus leads to spurious results (or at least results dependent on the arbitrary choice of negative redshift value). We should use something that is continuous past the age of the universe, i.e. time or scale-factor instead, so that we can more meaningfully continue to interpolate across.

The current implementation should be fairly conservative, so this is not expected to be a notable issue currently.

@lzkelley lzkelley added the bug Something isn't working label Jun 22, 2023
@lzkelley lzkelley self-assigned this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant