Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAC point memory layout in protocol differs from implementation in physical DACs #5

Open
mitchmindtree opened this issue Jun 8, 2018 · 1 comment

Comments

@mitchmindtree
Copy link
Member

The protocol specifies the layout as of DAC points as control, x, y, i, r, g, b, etc, however physical DACs seem to expect this order instead: control, x, y, r, g, b, i, etc. Not sure if this is a bug that has been fixed in newer DACs or if all DACs will expect this point layout and we should fix our protocol implementation.

@mitchmindtree mitchmindtree changed the title Colour byte order in protocol differs from implementation in physical DACs DAC point memory layout in protocol differs from implementation in physical DACs Jun 8, 2018
@mitchmindtree
Copy link
Member Author

If you're running into this issue, use the colour_layout branch.

We'll test the latest ether-dream DAC within the next couple of weeks and if that also uses the differing point layout, I'll merge the color_layout branch into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant