Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the binary on Winget #82

Closed
rehanhooda opened this issue Jun 29, 2021 · 8 comments · May be fixed by #189
Closed

Update the binary on Winget #82

rehanhooda opened this issue Jun 29, 2021 · 8 comments · May be fixed by #189

Comments

@rehanhooda
Copy link

Hi dev,

Could you update the OpenHashTab file on the winget repo? Currently, it is showing 2.3.0 version there.

image

Thanks,

@MisterX2000
Copy link

Yeah, I've also noticed that the pull request here microsoft/winget-pkgs#7037 has already been merged since February, but it's still not showing with the winget-cli.
But I also have no Idea, how the process behind it works, so ¯_(ツ)_/¯

@namazso
Copy link
Owner

namazso commented Jul 17, 2021

to be honest.. me neither, i just copied what the pr before me did

@djdv
Copy link

djdv commented Jul 18, 2021

In addition to the previous update PR, I saw this one microsoft/winget-pkgs#21601
Which targets v3.0.1 but I'm still seeing

> winget search openhashtab
Name        Id                  Version Source
-----------------------------------------------
OpenHashTab namazso.OpenHashTab 2.3.0   winget

Maybe an issue on their side that needs to be reported/resolved. It looks like their CI didn't like so maybe it's related.

@NotaInutilis
Copy link

NotaInutilis commented Sep 20, 2021

Digging this issue up a bit because, if i remember correctly, v3.0.1 was showing up at one point in the winget tool.

Also, I'd like to risk a barely educated guess: can this issue be caused by the "v" prefix? It's only on the 3.0.1 release, and not on the 2.3.0 one. Moreover, I believe it would make sense for an upgrade tool to put letters before numbers in its ordering system, because of some release going "alpha x" or "beta y" before 1.0.

Edit: somebody encountering the same problem with v-prefixes and it's been classified as a bug, so it's on winget's side.

@sitiom
Copy link
Contributor

sitiom commented Jul 26, 2023

Also, I'd like to risk a barely educated guess: can this issue be caused by the "v" prefix? It's only on the 3.0.1 release, and not on the 2.3.0 one.

You're right. I have created a PR to fix this:

As for auto-updating the Winget manifest, I have also created a PR to setup the Winget Releaser workflow:

@namazso
Copy link
Owner

namazso commented Jul 26, 2023

This was fixed on the Winget side already:

image

@namazso namazso closed this as completed Jul 26, 2023
@sitiom
Copy link
Contributor

sitiom commented Jul 26, 2023

This was fixed on the Winget side already:

image

That's because the 2.x versions were removed in Winget: microsoft/winget-pkgs#39284, microsoft/winget-pkgs#39285. I think the better solution was to trim off the v prefix on the OpenHashTab side.

@NotaInutilis
Copy link

NotaInutilis commented Jul 26, 2023

There seems to still be some wonky stuff with winget. It didn't upgrade OpenHashTab from 3.0.2 to 3.0.4 automatically with upgrade --all, I had to specifically ask for this package to upgrade.
Plus, the v prefix does not appear in OpenHashTab's Check update window, having a version x instead, so it'd better be cut off (or added) everywhere for consistency.
(And thanks you all folks for taking care of this sofware! Still very easy to use!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants