Regression - HTTP status code wrong on api errors

[Taloth]

First Affected Version: v0.8.1.0 (2017)

Steps to reproduce the behaviour

• Call the /api?t=abcd

Expected behaviour

HTTP Response with status code 200 OK, containing a xml error message <error code="202" description="No such function"/>

Actual behaviour

HTTP Response with status code 202 (Accepted), containing the correct xml error message.

Details

nZEDb/nzedb/utility/Misc.php

Line 997 in 48fef6d

http_response_code($status);

Causes every api error code to be used as http statuscode. So an 100 'invalid user credentials' would be returned as 'HTTP 100 Continue' Instead of 'HTTP 200 OK'.

Btw. Http status code 429 is a useful response when the user's grab limit has been exceeded. Which was originally attempted in commit 9ffe607.
Although ideally that should include a Retry-After header to supply the client with the appropriate delay until the next 'grab' becomes available. Probably better to have a separate function for that one.