Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

THREE deprecation warning for a function in tick() has caused my entire OS to crash. #183

Open
kylebakerio opened this issue Jan 11, 2021 · 2 comments

Comments

@kylebakerio
Copy link
Contributor

It's technically really the fault of THREE and A-Frame, to some extent, but since they refuse to deal with logging...

These calls:
https://github.com/n5ro/aframe-physics-system/search?q=inverse

now need to be invert, in the version of THREE that A-Frame is now using as of 1.1.0.

I know most of these are just, whatever, too much to keep up with, but because it's in a tick() handler, it's basically makes the console unusable, so it might be worth updating this one.

As I listed here first:
c-frame/aframe-super-hands-component#189

inverse | @ | three.js:37223
-- | -- | --
  | Body.syncFromPhysics | @ | aframe-physics-system.js:17403
  | step | @ | aframe-physics-system.js:17280
  | tick | @ | aframe-physics-system.js:19025
  | tick | @ | a-scene.js:746
  | render | @ | a-scene.js:790
  | bound | @ | bind.js:12

This was when using superhands with this library for physics.

@kylebakerio
Copy link
Contributor Author

Note that I did also mention this to A-Frame, as I really think they should handle it:
aframevr/aframe#4767

But I also don't think they will.

In the meantime I've just finally hacked console.log/warn/error globals myself and silenced them locally, but that feels a bit absurd, personally.

@kylebakerio
Copy link
Contributor Author

...I also think that checking if every warn message contains "THREE" in its first five chars hundreds to thousands of times per minute is still a significant overhead to the system, so I'm going to just try to do a built with those functions changed.

I'm happy to do a pull request, but I presume this will break for prior versions of A-Frame using prior versions of THREE. Either the code would need to be rewritten into some way to avoid the breaking function call (maybe just copy/pasting the .inverse()/invert() method itself as a hack for now? Maybe doing a THREE version check? I don't really have deep damiliarity with THREE or this library, so my ability beyond those two options is limited / would require extensive coming-up-to-speed that I doubt I'd get to), or this library would just have to list that projects using A-Frame prior to 1.04 require no newer version of aframe-physics-system.

Thoughts?

kylebakerio added a commit to kylebakerio/aframe-physics-system that referenced this issue Jan 12, 2021
kylebakerio added a commit to kylebakerio/aframe-physics-system that referenced this issue Jan 12, 2021
kylebakerio added a commit to kylebakerio/aframe-physics-system that referenced this issue Jan 12, 2021
@kylebakerio kylebakerio mentioned this issue Jan 12, 2021
n5ro added a commit that referenced this issue Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant