Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types as devDepednency? #118

Closed
Noitidart opened this issue Apr 27, 2018 · 1 comment
Closed

prop-types as devDepednency? #118

Noitidart opened this issue Apr 27, 2018 · 1 comment

Comments

@Noitidart
Copy link

So I was having problems building. For the longest time. I would get this error:

error: bundling failed: Error: Unable to resolve module prop-types from C:\Users\x1\Documents\GitHub\Trusted-Score-Mobile\node_modules\react-native\Libraries\Components\ActivityIndicator\ActivityIndicator.js: Module prop-types does not exist in the Haste module map

When it was tryign to bundle.

Finally I figured out i had to npm i prop-types because it is in the "dependencies". Should we maybe move it to "devDependencies"?

This was explained here - facebook/react-native#14302 (comment)

I'm just not sure. Do PropTypes stuff get stripped out in bundle procedure for production?

@n4kz
Copy link
Owner

n4kz commented Oct 9, 2019

Thanks for issue and sorry for delayed reply. Is this still happening in recent RN versions? Please let me know if problem is still there by commenting here or creating a new issue.

@n4kz n4kz closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants