Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toc should not change the undotree #26

Open
wsdjeg opened this issue Jun 28, 2017 · 4 comments
Open

Update toc should not change the undotree #26

wsdjeg opened this issue Jun 28, 2017 · 4 comments

Comments

@wsdjeg
Copy link
Contributor

wsdjeg commented Jun 28, 2017

When use this plugin to edit a md file, after saving file, the toc is updated, but when I type u the cursor move to the toc menu, I think the undotree of current file is been updated.

@wsdjeg
Copy link
Contributor Author

wsdjeg commented Jun 28, 2017

Maybe we should use :undojoin command, I will look into it to see if I can send a PR.

@mzlogin
Copy link
Owner

mzlogin commented Jun 29, 2017

Yes, that's a problem. We should not change the undolist when there is no toc change.

I'll look into it. And, welcome to PR for this.

@wsdjeg
Copy link
Contributor Author

wsdjeg commented Sep 7, 2017

I got another issue with this plugin, after save markdown file, `` in normal mode does not work, we can not jump to the position when last jump, but will jump to the beginning of TOC, I think it is due to how this plugin works.

I will look into this plugin, and I will fix it before SpaceVim/SpaceVim#806 is merged.

in this PR I will update SpaceVim's markdown layer.

@mzlogin
Copy link
Owner

mzlogin commented Sep 7, 2017

Yes, I reproduce it. Maybe we can get help from keepjumps. Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants