Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use engine field to enforce node version #45

Open
Aghassi opened this issue Nov 15, 2021 · 0 comments
Open

Use engine field to enforce node version #45

Aghassi opened this issue Nov 15, 2021 · 0 comments

Comments

@Aghassi
Copy link

Aghassi commented Nov 15, 2021

Node 16 is now LTS, which means this repo no longer needs to be forward and backwards compatible between zlib and iltorb. In particular, this also solves another problem my org is facing which is that iltorb compilation is a cache miss under bazel because it leaves files with SHAs in them. Enforcing LTS versioning and dropping iltorb from the dep list would solve both of these problems. It would be considered a major, but it's a good move in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant