Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package #57

Open
p0o opened this issue Sep 17, 2018 · 7 comments
Open

NPM package #57

p0o opened this issue Sep 17, 2018 · 7 comments

Comments

@p0o
Copy link

p0o commented Sep 17, 2018

Is it possible to have an NPM package published for this repository? Preferably with a babel build script to publish the ES5 code so it wouldn't be rejected by React build environments.

@p0o p0o changed the title NPM module NPM package Sep 17, 2018
@paulshapiro
Copy link
Contributor

You can already install it over npm by specifying the git repo as there's a package.json and index.

I would generally be fine with the npm registry listing this repo but just be aware that you run a security risk by having that layer of automation... something I would tend to try to avoid recommending for such a sensitive library.

@p0o
Copy link
Author

p0o commented Sep 17, 2018

Yes, you are right about installing git repo using NPM, however, the master branch is not ES5 friendly (needs a bable build with a dist folder) and I'm not sure if cpp branch is production ready?

@paulshapiro
Copy link
Contributor

paulshapiro commented Sep 17, 2018

The master branch has been built to es5 successfully by many people…

Cpp is close to or at production readiness. More people should test it.

@paulshapiro
Copy link
Contributor

What would be done to the cpp branch which could not be done to the master branch anyway? I would accept a working PR .

@p0o
Copy link
Author

p0o commented Sep 17, 2018

The master branch has been built to es5 successfully by many people…

Yes I also put it in my webpack build but it's adding extra time to my environment build time and many standard webpack builds would ignore node_modules folder for build. It's common for JS dependencies to include a dist folder for prebuilt files to avoid these kind of issues.

@paulshapiro
Copy link
Contributor

Feel free to submit fixes via PR. This is a community project :)

@p0o
Copy link
Author

p0o commented Sep 17, 2018

Sure, will submit soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants