-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: update to cheminfo-types #6
Conversation
"eslint-plugin-import": "^2.25.2", | ||
"eslint-plugin-jest": "^25.2.1", | ||
"eslint-plugin-jsdoc": "^37.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be necessary
"@typescript-eslint/eslint-plugin": "^5.0.0", | ||
"@typescript-eslint/parser": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this error if I delete it
ESLint: 8.1.0
Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.yml » eslint-config-cheminfo-typescript#overrides[0]': Cannot find module '@typescript-eslint/parser'
Require stack:
- /home/runner/work/ndim-parser/ndim-parser/node_modules/eslint-config-cheminfo-typescript/index.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
at Function.resolve (internal/modules/cjs/helpers.js:99:19)
at Object.resolve (/home/runner/work/ndim-parser/ndim-parser/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:1088:46)
at ConfigArrayFactory._loadParser (/home/runner/work/ndim-parser/ndim-parser/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3235:39)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/runner/work/ndim-parser/ndim-parser/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3030:43)
at _normalizeObjectConfigDataBody.next (<anonymous>)
at ConfigArrayFactory._normalizeObjectConfigData (/home/runner/work/ndim-parser/ndim-parser/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2971:20)
at _normalizeObjectConfigData.next (<anonymous>)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/runner/work/ndim-parser/ndim-parser/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3064:25)
at _normalizeObjectConfigDataBody.next (<anonymous>)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need npm 7 or 8 (node 16 or 17)
BREAKING CHANGE: rename data to variables