Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Bottom Menu is a bit strange #1

Open
ooade opened this issue Oct 13, 2018 · 9 comments
Open

The Bottom Menu is a bit strange #1

ooade opened this issue Oct 13, 2018 · 9 comments

Comments

@ooade
Copy link

ooade commented Oct 13, 2018

  • Initially, I didn't even know there was a bottom menu
  • Active Menus does not look active when active 😅 i.e Piano seem active while Drums is active and Vice Versa.
  • Jam doesn't seem to work. I haven't gone through the code tho.

BTW, Nice project. I got to know about express-ws. Dived into that 😸

@mykeels
Copy link
Owner

mykeels commented Oct 13, 2018

Thanks, Demola.

Where would you suggest the menu be?

Jam isn't available as a feature yet, so it should probably be taken away.

Yep, I like express-ws cos its abstraction fits into express' pipeline smoothly

@ooade
Copy link
Author

ooade commented Oct 13, 2018

The Menu could be on top or may be fixed to the bottom. The latter may not play well with the Piano. Besides, the current position seems to be the best option for the Piano 😅

@mykeels
Copy link
Owner

mykeels commented Oct 13, 2018

How about indicators that point users to the bottom when they first load the app?

@ooade
Copy link
Author

ooade commented Oct 13, 2018

@mykeels Yeah. That's awesome 🔥 🔥 🔥

@mykeels
Copy link
Owner

mykeels commented Oct 14, 2018

Here's what the bottom menu should look like

image

  • The white border color signifies the tab is "active"
  • The "Jam" menu item is removed till it's available

Still no updates on the indicator that tells users about the menu at the bottom. I don't even know what it's normally called 😄Maybe make a separate issue for that, if it's necessary?

@ooade
Copy link
Author

ooade commented Oct 14, 2018

Yeah. LGTM!
I don't know what that indicator is called too 😅
Hey @whizkydee, WDYT?

@whizkydee
Copy link

Great job on this, @mykeels!

Just checked out the app and I was quite confused too about which button was active. I'm in support of this implementation though – easy to understand.

@ooade, an indicator is an indicator, no special term for that. I'm not sure though; what kind of indicator are y'all talking about?

@ooade
Copy link
Author

ooade commented Oct 14, 2018

@whizkydee Indicator, like an arrow pointing down immediately the component get rendered to let the user know there's a menu bar below.

@whizkydee
Copy link

Oh yeah, totally. Actually, the menu should be at the top. It's much more accessible there.

I also think you can reduce the height of the menu and strip off the additional <span> below those buttons. It's totally irrelevant. I'm sure that was just a quick copy-paste thing, @mykeels -- understandable.

I think we can forget about the indicator once this is done. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants