{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":127742296,"defaultBranch":"master","name":"x","ownerLogin":"myitcv","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-04-02T10:36:28.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3374574?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1707558837.0","currentOid":""},"activityList":{"items":[{"before":"6b65b213cf81d14d11a3c8505dfdab41e65c90ad","after":null,"ref":"refs/heads/unset_gotraceback","pushedAt":"2024-02-10T09:54:54.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"}},{"before":"e8a4520f015e84a8892282bc3b464059dc555819","after":"5fef39cd83c3445b70d17f5352ce10a55c06683d","ref":"refs/heads/master","pushedAt":"2024-02-10T09:54:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/unsharemounts: unset GOTRACEBACK (#186)\n\nIt is only set because unsharemounts is run setuid. But unshare mounts\r\ndowngrades to user mode, so unsetting it is safe and correct.\r\n\r\nUse the go 1.22.0 toolchain while we are here.","shortMessageHtmlLink":"cmd/unsharemounts: unset GOTRACEBACK (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2128264755\" data-permission-text=\"Title is private\" data-url=\"https://github.com/myitcv/x/issues/186\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/myitcv/x/pull/186/hovercard\" href=\"https://github.com/myitcv/x/pull/186\">#186</a>)"}},{"before":null,"after":"6b65b213cf81d14d11a3c8505dfdab41e65c90ad","ref":"refs/heads/unset_gotraceback","pushedAt":"2024-02-10T09:53:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/unsharemounts: unset GOTRACEBACK\n\nIt is only set because unsharemounts is run setuid. But unshare mounts\ndowngrades to user mode, so unsetting it is safe and correct.\n\nUse the go 1.22.0 toolchain while we are here.","shortMessageHtmlLink":"cmd/unsharemounts: unset GOTRACEBACK"}},{"before":"4fde1857bf7f956215c4fcae9ba2b143ba20deb1","after":"e8a4520f015e84a8892282bc3b464059dc555819","ref":"refs/heads/master","pushedAt":"2023-06-23T10:13:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/newshell: further hack for spawning from tip version","shortMessageHtmlLink":"cmd/newshell: further hack for spawning from tip version"}},{"before":"084d859c314932737cb7e4677519d204d7eee282","after":null,"ref":"refs/heads/fix_unshare_suage","pushedAt":"2023-06-23T10:04:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"}},{"before":"a7167afc9e13880295c3494d3354c800dbc34351","after":"4fde1857bf7f956215c4fcae9ba2b143ba20deb1","ref":"refs/heads/master","pushedAt":"2023-06-23T10:04:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/(unsharemounts|mountwrap): fix usage of unshare (#185)\n\nWith the move to Debian, we now mount /home onto a separate device. This\r\nmeans that the old approach of calling --make-private on / no longer\r\nworks, because /home is still shared.\r\n\r\nIt's also unclear how calling mount --make-private / worked, because\r\nthis happened in a child process of the shell in which we had previously\r\ncalled unshare.\r\n\r\nLooking at the example in unshare(1), that seems to suggest the call to\r\nunshare and the call to mount --make-private should happen in the\r\nparent/current process. Mainly because repeatedly making that call will\r\nhave no effect - calling it once should suffice.\r\n\r\nThe docs in unshare(1) are also somewhat unclear on the order in which\r\nthe calls should be made:\r\n\r\n  $ mount --bind /root/namespaces /root/namespaces\r\n  $ mount --make-private /root/namespaces\r\n  $ touch /root/namespaces/mnt\r\n  $ unshare --mount=/root/namespaces/mnt\r\n\r\nFor now it seems like the most sensible thing to do is to call unshare\r\nfirst (to create a separate mount namespace), then make the mount\r\nprivate to the new namespace.\r\n\r\nAlso fix up newshell. There is lots of bad code in this repo, much hard\r\ncoding of values... but for now it works again.","shortMessageHtmlLink":"cmd/(unsharemounts|mountwrap): fix usage of unshare (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1771180793\" data-permission-text=\"Title is private\" data-url=\"https://github.com/myitcv/x/issues/185\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/myitcv/x/pull/185/hovercard\" href=\"https://github.com/myitcv/x/pull/185\">#185</a>)"}},{"before":"eb29733e3dc561f51fc57e3d651ff2a766adf216","after":"084d859c314932737cb7e4677519d204d7eee282","ref":"refs/heads/fix_unshare_suage","pushedAt":"2023-06-23T10:03:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/(unsharemounts|mountwrap): fix usage of unshare\n\nWith the move to Debian, we now mount /home onto a separate device. This\nmeans that the old approach of calling --make-private on / no longer\nworks, because /home is still shared.\n\nIt's also unclear how calling mount --make-private / worked, because\nthis happened in a child process of the shell in which we had previously\ncalled unshare.\n\nLooking at the example in unshare(1), that seems to suggest the call to\nunshare and the call to mount --make-private should happen in the\nparent/current process. Mainly because repeatedly making that call will\nhave no effect - calling it once should suffice.\n\nThe docs in unshare(1) are also somewhat unclear on the order in which\nthe calls should be made:\n\n  $ mount --bind /root/namespaces /root/namespaces\n  $ mount --make-private /root/namespaces\n  $ touch /root/namespaces/mnt\n  $ unshare --mount=/root/namespaces/mnt\n\nFor now it seems like the most sensible thing to do is to call unshare\nfirst (to create a separate mount namespace), then make the mount\nprivate to the new namespace.\n\nAlso fix up newshell. There is lots of bad code in this repo, much hard\ncoding of values... but for now it works again.","shortMessageHtmlLink":"cmd/(unsharemounts|mountwrap): fix usage of unshare"}},{"before":null,"after":"eb29733e3dc561f51fc57e3d651ff2a766adf216","ref":"refs/heads/fix_unshare_suage","pushedAt":"2023-06-23T08:43:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"myitcv","name":"Paul Jolly","path":"/myitcv","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3374574?s=80&v=4"},"commit":{"message":"cmd/(unsharemounts|mountwrap): fix usage of unshare\n\nWith the move to Debian, we now mount /home onto a separate device. This\nmeans that the old approach of calling --make-private on / no longer\nworks, because /home is still shared.\n\nIt's also unclear how calling mount --make-private / worked, because\nthis happened in a child process of the shell in which we had previously\ncalled unshare.\n\nLooking at the example in unshare(1), that seems to suggest the call to\nunshare and the call to mount --make-private should happen in the\nparent/current process. Mainly because repeatedly making that call will\nhave no effect - calling it once should suffice.\n\nThe docs in unshare(1) are also somewhat unclear on the order in which\nthe calls should be made:\n\n  $ mount --bind /root/namespaces /root/namespaces\n  $ mount --make-private /root/namespaces\n  $ touch /root/namespaces/mnt\n  $ unshare --mount=/root/namespaces/mnt\n\nFor now it seems like the most sensible thing to do is to call unshare\nfirst (to create a separate mount namespace), then make the mount\nprivate to the new namespace.","shortMessageHtmlLink":"cmd/(unsharemounts|mountwrap): fix usage of unshare"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD9yxNzAA","startCursor":null,"endCursor":null}},"title":"Activity · myitcv/x"}