Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent in args vs kwargs #128

Open
lukasjuhrich opened this issue Jul 24, 2016 · 0 comments
Open

Be consistent in args vs kwargs #128

lukasjuhrich opened this issue Jul 24, 2016 · 0 comments

Comments

@lukasjuhrich
Copy link
Contributor

lukasjuhrich commented Jul 24, 2016

Glancing over the source, I often find kwargs.update(args). Also, in Listing.__init__ of listing.py:

        data = self.site.api(
            'query', (self.generator, self.list_name),
            *[(text_type(k), v) for k, v in six.iteritems(self.args)]
        )

What reason is there for this duality of 2-tuples as arguments vs keyword arguments? Why not just consistently use keyword arguments?

If there is a reason for it, documenting it might be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant