Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove auto theme switch based on OS appearance #43

Closed
muuvmuuv opened this issue Dec 9, 2019 · 1 comment
Closed

[FEATURE] Remove auto theme switch based on OS appearance #43

muuvmuuv opened this issue Dec 9, 2019 · 1 comment
Labels
enhancement New feature or request external

Comments

@muuvmuuv
Copy link
Owner

muuvmuuv commented Dec 9, 2019

Is your feature request related to a problem? Please describe.

Because I'm going to implement this feature natively to VS Code, this isn't longer needed in Sundial.

Describe the solution you'd like

Remove it from Sundial core and add a hint that any other feature in Sundial would need the options in Code colorThemeAutoSwitch to be off (or whatever the option will be named in release)

Describe alternatives you've considered

None

Additional context

@muuvmuuv muuvmuuv added enhancement New feature or request external labels Dec 9, 2019
@mikestopcontinues
Copy link

Thanks for all the work you're doing on this. It's totally ace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external
Projects
None yet
Development

No branches or pull requests

2 participants