Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bin/conpot #540

Open
glaslos opened this issue Nov 22, 2020 · 4 comments
Open

Refactor bin/conpot #540

glaslos opened this issue Nov 22, 2020 · 4 comments

Comments

@glaslos
Copy link
Member

glaslos commented Nov 22, 2020

  • Would be nice if it can be a file conpot.py with Python extension. setup.py needs to be updated to make this possible.
  • The file should only do flags, startup message and initializing/running Conpot.
  • Everything template should be in a separate module.
  • Everything starting protocols should be in a separate module.
  • Everything logging should be in separate module.
  • Everything moved into a separate module should have test coverage.
@NishantPuri99
Copy link

Hi, Can I try this out?

@glaslos
Copy link
Member Author

glaslos commented Jan 10, 2021

Of course, no need to ask :)

@srenfo
Copy link
Contributor

srenfo commented Jan 30, 2021

Ideally there would also be tests where possible. Don't know if you want to add this to the requirements.

I realize that testing main() is notoriously difficult, but with a split in separate modules (or at least functions) this should be much easier.

@glaslos
Copy link
Member Author

glaslos commented Feb 20, 2022

@NishantPuri99 have you had any success?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.7 Release
  
To do
Development

No branches or pull requests

3 participants