Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote event error feedback should be suppressed during node recycle #288

Open
justparking opened this issue Feb 23, 2023 · 2 comments
Open
Assignees

Comments

@justparking
Copy link
Contributor

This occurred during a node restart:

Remote event handling failed - java.lang.IllegalStateException: Event handling failure (internal server error) - 'remote_event_IPAddress'-

Remote event handler error feedback could be suppressed if the toolkit is being shutdown or already shutdown.

@justparking justparking self-assigned this Feb 23, 2023
@justparking justparking changed the title Error suppression on Remote event error feedback should be suppressed during node recycle Feb 23, 2023
@justparking
Copy link
Contributor Author

The same applies to active HTTP calls - they can fail silently too.

Or anything that's done via the toolkit.

And if not entirely suppressed, dumping an entire stack trace can be avoided.

@justparking
Copy link
Contributor Author

The same should apply to action, emit and call handlers, e.g. after a recycle this might happen where the error is simply because the node it restarting.

05-24 09:23:38.36 (action) Traceback (most recent call last):
05-24 09:23:38.37   File "/opt/nodel/./nodes/Frontend/ingredient_echo.py", line 7, in EchoRequest
05-24 09:23:38.37     local_event_EchoReply.emit(arg)
05-24 09:23:38.37 AttributeError: 'dict' object has no attribute 'emit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant