Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile is too architecture specific while it should not #46

Open
Narann opened this issue Mar 10, 2015 · 1 comment
Open

Makefile is too architecture specific while it should not #46

Narann opened this issue Mar 10, 2015 · 1 comment
Labels

Comments

@Narann
Copy link
Member

Narann commented Mar 10, 2015

@Nebuleon tried to compile color combiner refactoring and get this error:

Makefile:118: *** CPU type "mips" not supported. Please file bug report at 'http://code.google.com/p/mupen64plus/issues'. Stop.
make[1]: Leaving directory `/storage/programming/mupen64plus/mupen64plus-video-rice/projects/unix'
because I build with parallel make, other projects built fine, but not this one
Your project is not architecture-specific; it's disingenuous to have the checks. I undid some of them in commits like mupen64plus/mupen64plus-input-sdl@630e4c7

As Rice does not rely on arch specific opcode, we should remove the check from the Makefile

@Narann
Copy link
Member Author

Narann commented Mar 10, 2015

Thanks Nebulon. I'm not a compilation expert so I would wait for @richard42 comment on this before accept the PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant