Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong special characters are used #71

Open
Jj0YzL5nvJ opened this issue May 17, 2021 · 4 comments
Open

Wrong special characters are used #71

Jj0YzL5nvJ opened this issue May 17, 2021 · 4 comments

Comments

@Jj0YzL5nvJ
Copy link
Contributor

test_cp1252.zip
@Jj0YzL5nvJ Jj0YzL5nvJ mentioned this issue May 17, 2021
Closed
@Narann
Copy link
Member

Narann commented May 17, 2021

I'm not sure it's a mupen bug. What happen if you open a terminal in the problematic folder?

@Jj0YzL5nvJ
Copy link
Contributor Author

Jj0YzL5nvJ commented May 18, 2021 •
edited

https://imgur.com/a/zyP38QL
https://imgur.com/a/5RFNy85

@Jj0YzL5nvJ
Copy link
Contributor Author

Jj0YzL5nvJ commented May 18, 2021 •
edited

It appears that an unnecessary string conversion is being performed.
https://imgur.com/a/OtmpuZY

mupen64plus/mupen64plus-core#688
loganmc10/m64p#157

Edit:
Sorry, I packed the wrong text file (test2.txt vs hmm.txt).
Fixed - test2.zip

@Jj0YzL5nvJ Jj0YzL5nvJ changed the title Minor bug - Wrong special characters are displayed (cp1252?) Wrong special characters are used May 18, 2021
@loganmc10
Copy link
Member

loganmc10 commented May 31, 2021 •
edited

I don't think mupen64plus-core really supports Unicode/UTF-8 on Windows.

mupen64plus-core uses fopen (and similar functions). This works for UTF-8 on Linux, however on Windows you need to use _wfopen and pass it a wchar_t/UTF-16 string.

Those functions should be brought into "osal" and have separate implementations for Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Narann @loganmc10 @Jj0YzL5nvJ