Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LastRunWithNoErrors in ManagedInstallReport.plist #1145

Open
iamharlie opened this issue Jun 16, 2022 · 3 comments
Open

Include LastRunWithNoErrors in ManagedInstallReport.plist #1145

iamharlie opened this issue Jun 16, 2022 · 3 comments

Comments

@iamharlie
Copy link

iamharlie commented Jun 16, 2022

We're running a script on the client and trying to determine when Munki last ran successfully. To us, successfully means returning no errors. The current plist values are not enough to accomplish this statelessly, because the run times are recorded regardless of returned errors.

I'd like to request adding "LastRunWithNoErrors" to the ManagedInstallReport.plist

A PR was opened a few years back and never merged but I'm not sure it works: #793

@gregneagle
Copy link
Contributor

This would not be something I plan to work on any time soon. If someone wanted to try to update that PR, I'd look at it.

@gregneagle
Copy link
Contributor

I note that Mike's PR only looked at Errors and not Warnings (https://github.com/munki/munki/pull/793/files), which further underlines my initial concern: that different admins/orgs will define this state differently...

@iamharlie
Copy link
Author

I note that Mike's PR only looked at Errors and not Warnings (https://github.com/munki/munki/pull/793/files), which further underlines my initial concern: that different admins/orgs will define this state differently...

That’s just my mistake in writing the issue up, if the name is LastRunWithNoErrors it should only include errors. I changed the original issue to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants