Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ventura_upgrade_supported.py and sonoma_upgrade_supported.py are returning False on vm's #33

Open
SoxIn4 opened this issue Mar 18, 2024 · 1 comment

Comments

@SoxIn4
Copy link
Contributor

SoxIn4 commented Mar 18, 2024

I'm not in a position to make a pull request right now, but I found that the monterey version has this at the top of its sysctl function, and it's missing in the newer versions:

if isinstance(name, str):
name = name.encode('utf-8')

Adding that to the new versions seems to work in my local testing. (Can't test for real until Wed.)

@SoxIn4 SoxIn4 changed the title ventura_upgrade_supported.py and sonoma_upgrade_supported.py are returning Fals on vm's ventura_upgrade_supported.py and sonoma_upgrade_supported.py are returning Fails on vm's Mar 18, 2024
@SoxIn4 SoxIn4 changed the title ventura_upgrade_supported.py and sonoma_upgrade_supported.py are returning Fails on vm's ventura_upgrade_supported.py and sonoma_upgrade_supported.py are returning False on vm's Mar 18, 2024
@gregneagle
Copy link
Contributor

Untested, but 9784266 should address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants