Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jstat* plugin category 'virtualization' is very non-obvious + munin-core jmx_ plugin uses 'jvm' as category also #964

Open
shuehner opened this issue Dec 13, 2018 · 4 comments

Comments

@shuehner
Copy link
Contributor

Hello,
commit 8d9fe5b reduced number of categories which in general makes sense.

However in case of the 3 jstat* plugins (Java Memory related) i find the newly used category 'virtualization' very confusing and not obvious to find at all.

while JVM is 'Java Virtual Machine' i think most people would not relate Java to 'virtualization' which is imho rather virtual machines, containers, etc..

Apart looking at at munin main repo jmx_ plugin also monitoring Java that one sues 'jvm' as category by default:
https://github.com/munin-monitoring/munin/blob/master/plugins/javalib/org/munin/plugin/jmx/Config.java#L42

So what about reverting that earlier category change here in contrib for those 3 plugins?

@sumpfralle
Copy link
Collaborator

How about appserver?

@pdurbin
Copy link

pdurbin commented Jul 23, 2019

I also found it confusing to find the jstat stuff under "virtualization". It looks like "postgresql" gets its own category...

Screen Shot 2019-07-23 at 1 27 44 PM

... so maybe we could have a category called "jvm"?

I don't love "appserver" because there are plenty of applications written in Java that aren't app servers. Solr, Elasticsearch, and Jenkins come to mind.

p.s. I just looked at 8d9fe5b and see that jstat and friends used to be under "java". I'm fine with this too. "java" or "jvm".

@sumpfralle
Copy link
Collaborator

Munin supports only a single category to be assigned to each plugin. This makes it a bit hard to use a perspective, that is useful for everyone.

As described in the list of well-known plugin categories, the perspective of generic terms was picked. In contrast java or jvm would be language-oriented.

A good solution for this would be to support multiple categories per plugin. This is not allowed at the moment, I think.

@steveschnepp: would this be a useful approach from your point of view?

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants