Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Cargo.lock #562

Open
Samuel-Bowden opened this issue May 6, 2024 · 1 comment · May be fixed by #563
Open

Missing Cargo.lock #562

Samuel-Bowden opened this issue May 6, 2024 · 1 comment · May be fixed by #563

Comments

@Samuel-Bowden
Copy link

Hello, I have been working on writing a Nix derivation for this project with the aim of compiling and installing Mun on NixOS, and I've noticed that the workspace does not include a Cargo.lock file, which is required to create a deterministic derivation.

I am unsure if the absence of Cargo.lock is intentional or an oversight. Should we consider adding a Cargo.lock to the workspace?

@baszalmstra
Copy link
Collaborator

Mun is both an executable and a library.

For libraries I tend not to include a lock file.
But for the executable, it makes sense to have a lock file.

Since a lock-file always applies to all crates in the project lets just add it.

@Samuel-Bowden Samuel-Bowden linked a pull request May 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants