Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Miri and fix issues #420

Open
1 of 7 tasks
Wodann opened this issue Jul 7, 2022 · 1 comment
Open
1 of 7 tasks

Run Miri and fix issues #420

Wodann opened this issue Jul 7, 2022 · 1 comment
Assignees
@belagoesr
Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: fix Bug fix or report

Comments

@Wodann
Copy link
Collaborator

Wodann commented Jul 7, 2022 •
edited

  • claim this issue (assign yourself or comment below)
  • setup repository on your local machine and make sure all tests pass (cargo test)
  • read our contributing guidelines
  • run Miri on the mun codebase
  • fix all errors and warnings reported by Miri
  • (BONUS) add a ci job for running Miri
  • start a Pull Request. Set description to closes #420. If this is your first PR, welcome 🎉 😄
@Wodann Wodann added good first issue Good for newcomers type: perf Changes that improve performance exp: low Achievable with little prior knowledge and guidance pri: low An issue with no impact to quality, performance, or functionality labels Jul 7, 2022
@belagoesr
Copy link
Contributor

I'll be taking this one!

@belagoesr belagoesr mentioned this issue Oct 31, 2023
Merged
@Wodann Wodann added type: fix Bug fix or report and removed type: perf Changes that improve performance labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belagoesr belagoesr

Labels
exp: low Achievable with little prior knowledge and guidance good first issue Good for newcomers pri: low An issue with no impact to quality, performance, or functionality type: fix Bug fix or report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wodann @belagoesr