Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String type #418

Open
aghoneim92 opened this issue Jul 6, 2022 · 3 comments
Open

String type #418

aghoneim92 opened this issue Jul 6, 2022 · 3 comments
Labels
tracking Tracking issue for an epic

Comments

@aghoneim92
Copy link

I would like to add the String type to mun. Any pointers on where to start would be greatly appreciated :)

@baszalmstra
Copy link
Collaborator

We dont have any support for this currently and its also not yet planned or designed at all. I imagine that we'd implement similar to how we implement arrays now.

@Wodann what do you think? Should strings be a build-in type, similar to how arrays work? Or should we implement strings on top of arrays?

@Wodann
Copy link
Collaborator

Wodann commented Jul 7, 2022

It might be good for us to discuss a design during our next Mun jam and provide that as a guideline for how it can be implemented.

In general, I'd be in favour of implementing it in the Mun standard library. The less complicated our compiler and runtime, the better. However, we'll have to take several things into account that make it hard to say one way or another - at this point:

  • ability to marshal a string - using the C ABI - in both mun_runtime and our C++ Runtime
  • ability to hot reload strings

@Wodann Wodann added the tracking Tracking issue for an epic label Jan 2, 2023
@catchouli
Copy link

Ah bummer, I wanted to use this in my next project after seeing the 0.4.0 release on reddit, but after integrating it into my application (which was amazingly simple) and trying to write a logging function I quickly realized that strings aren't supported at all yet!

Shame too, this seems like an amazing project otherwise and seems plenty mature for early use, and I'm looking forward to using it in the future when strings are supported. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking Tracking issue for an epic
Projects
None yet
Development

No branches or pull requests

4 participants