Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly title without javascript #24

Open
hsanjuan opened this issue Mar 1, 2017 · 3 comments
Open

Ugly title without javascript #24

hsanjuan opened this issue Mar 1, 2017 · 3 comments

Comments

@hsanjuan
Copy link
Contributor

hsanjuan commented Mar 1, 2017

It says "Star" in h1 or so because it cannot show the github button:

image

@ghost
Copy link

ghost commented Mar 1, 2017

Another NoScript user! x)

Yeah it should probably degrade more gracefully, it's totally expected that people will open the page without an internet connection

@Kubuxu
Copy link
Member

Kubuxu commented Mar 1, 2017

It also happens with uMatix when I don't allow buttons.github.com.

@victorb
Copy link
Member

victorb commented Mar 1, 2017

True that, should be just a static image and then upgrading if JS is present. I also spotted in the source that there is something going on with the headers:

var lsymbol = '<span id="link-symbol">#</span>'
document.querySelectorAll('h1, h2, h3, h4, h5, h6, h7').forEach(function(h) {
var link = '<a class="header-link no-decoration" href="#' + h.id + '">'
h.innerHTML = link + lsymbol + h.innerHTML + '</a>'
})

We should make sure that happens on build-time as well, instead of on runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants