Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export libp2p_identity::PeerId? #107

Open
dav1do opened this issue Jan 5, 2024 · 1 comment
Open

Re-export libp2p_identity::PeerId? #107

dav1do opened this issue Jan 5, 2024 · 1 comment

Comments

@dav1do
Copy link

dav1do commented Jan 5, 2024

While updating a project with dependencies on multiaddr and multihash, I noticed that libp2p_identity::PeerId isn't re-exported but is in two public interfaces: MultiAddr::with_p2p and Protocol::P2p. Any objections to a re-export (or a wrapper tuple struct with Deref/DerefMut)? I'm happy to make a PR, but I figured I'd ask first as it has dependency/API ramifications.

I know the libp2p-identity crate is small so I could add it, but it'd be nice to have this library be self contained. I have an API that looks like a tiny bit of IPFS, which is why I want address info without actually pulling in libp2p proper.

@thomaseizinger
Copy link
Contributor

A re-export of PeerId seems fine to me, yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants