Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to be compatible with Leaflet 1.3.1 #10

Open
mukil opened this issue Nov 21, 2016 · 4 comments
Open

Adapt to be compatible with Leaflet 1.3.1 #10

mukil opened this issue Nov 21, 2016 · 4 comments

Comments

@mukil
Copy link
Owner

mukil commented Nov 21, 2016

No description provided.

@mukil
Copy link
Owner Author

mukil commented Nov 21, 2016

I can confirm that this plugin does not run out-of-the-box when using Leaflet 1.0.
So, as assumed, using Leaflet 0.7.7 is required.

@mukil mukil changed the title Test drive Leaflet.annotate for Leaflet 0.7 with Leaflet 1.0 Adapt to be compatible with Leaflet 1.0 Nov 21, 2016
@mukil mukil changed the title Adapt to be compatible with Leaflet 1.0 Adapt to be compatible with Leaflet 1.3.1 Mar 28, 2018
@mukil
Copy link
Owner Author

mukil commented Mar 28, 2018

@mukil
Copy link
Owner Author

mukil commented Mar 28, 2018

The way to go now seems to be one of the following ways:

  • L.Class.include() and addInitHook to run extra constructor code.
  • Implementing a Handler

The current implementation uses the approach of "Changing parts of an existing class (replacing how a class method works)" and this seems to be to tightly coupled to unforeseeable changes in upcoming versions of LeafletJS.

@mukil
Copy link
Owner Author

mukil commented Mar 28, 2018

But to keep the backwards-compatibility for automatically annotating web maps already created with Leaflet, the Leaflet-Schema.org-Dubine Core integration should continue to be tightly coupled with at least the following items of the Leaflet Standard API: Marker, CircleMarker, Popup, ImageOverlay and GeoJSON (as does Leaflet.annotate 0.3 do through building annotations on custom properties in the respective options object, see API Doc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant