Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] TextField with icon #6368

Closed
ifndefdeadmau5 opened this issue Mar 18, 2017 · 4 comments
Closed

[TextField] TextField with icon #6368

ifndefdeadmau5 opened this issue Mar 18, 2017 · 4 comments
Labels
component: text field This is the name of the generic UI component, not the React module!

Comments

@ifndefdeadmau5
Copy link
Contributor

ifndefdeadmau5 commented Mar 18, 2017

Problem description

2017-03-18 20 25 57

I'm wondering that would it be useful if displaying icon feature added in TextField.
But I'm not sure that is matches with Material Design guide? Looking forward to hearing from other guys!

Link to minimally-working code that reproduces the issue

It may looks like this

    <TextField
      hintText="With success icon"
      hasIcon={true}
    />
    <br />
    <TextField
      hintText="With error icon"
      hasIcon={true}
      iconButton={<Error />}
      iconStyle={{fill: '#757575'}}

Versions

  • Material-UI: v0.17.1
  • React: 15.4.0
  • Browser:
@mbrookes
Copy link
Member

Dupe of #2932.

@ifndefdeadmau5
Copy link
Contributor Author

ifndefdeadmau5 commented Mar 19, 2017

@mbrookes I think the position of icon is slightly different with that previous issue since in my example they're at inside of TextField while #2932 's one is at the outside. Also it seems there is still no any progress since then.

I had already implemented this feature in my branch and I was just curious whether could I make a PR or not.

@mbrookes
Copy link
Member

@ifndefdeadmau5 No, no progress, which is why the other issue is still open. Are you were interested discussing how to achieve this on the next branch? If so, please pick it up on the existing issue. Thanks!

@ifndefdeadmau5
Copy link
Contributor Author

@mbrookes Oh okay, thank you for letting me know that!

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: text field This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

4 participants