Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using inline style #6054

Closed
gop-aroy opened this issue Feb 3, 2017 · 2 comments
Closed

Stop using inline style #6054

gop-aroy opened this issue Feb 3, 2017 · 2 comments
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@gop-aroy
Copy link

gop-aroy commented Feb 3, 2017

Can you please remove every inline style… Every web integrator will tell you this is so deprecated… It makes really difficult to use your library.

Style shouldn't be directly in Javascript… CSS has been invented for this. You can consult this article explaining CSS selector value calculation here : https://css-tricks.com/specifics-on-css-specificity/

Thank you.
@lucasbento
Copy link

There already is an issue covering our current styling solution and the next one: #4066.

@gop-aroy
Copy link
Author

gop-aroy commented Feb 3, 2017

Nice !

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oliviertassinari @lucasbento @gop-aroy @zannager