Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-tap-event-plugin errors with latest react 15.4.0-rc.4 installed by create-react-app #5396

Closed
srinathh opened this issue Oct 15, 2016 · 11 comments
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation external dependency Blocked by external dependency, we can’t do anything about it

Comments

@srinathh
Copy link

react-tap-event-plugin errors with latest react 15.4.0-rc.4 installed by create-react-app

Versions

  • Material-UI: 0.16.0
  • React: 15.4.0-rc.4
  • Browser: Chrome Version 53.0.2785.143 (64-bit)
  • react-tap-event-plugin: 1.0.0

the create-react-app tool automatically installs the latest react release. With these versions, the react-tap-event-plugin throws a whole bunch of errors. It appears FB's removed a bunch of libraries in the latest React releases that the react-tap-event-plugin depends on and this will no longer work.

Module not found: 'react/lib/EventPluginHub'
Module not found: 'react/lib/EventConstants' 
Module not found: 'react/lib/EventPluginUtils' 
Module not found: 'react/lib/EventPropagators' 
Module not found: 'react/lib/SyntheticUIEvent' 
Module not found: 'react/lib/ViewportMetrics'

I find in issue #4670 that there are plans to remove the dependency in material-ui@next but it has not yet when I tried upgrading to it. Basically I'm forced to downgrade everything to versions that worked for me last time.

    "material-ui": "^0.15.4",
    "react": "^15.3.2",
    "react-dom": "^15.3.2" 

Given the usefulness of create-react-app, it may be good to document this issue in the installation instructions and accelerate a push of material-ui@next that fixes the issue

@lucasbento lucasbento added bug 🐛 Something doesn't work docs Improvements or additions to the documentation external dependency Blocked by external dependency, we can’t do anything about it labels Oct 22, 2016
@TimoRuetten
Copy link

Looking forward for an update. Currently its a mess to downgrade a lot packages just because of this issue.

@brendonlamb
Copy link

:( what's the solution to this? Stay on React 15.3.2?

@stevewillard
Copy link
Contributor

There's a new version of material-ui and react out. Just upgrade them both.

@brendonlamb
Copy link

Still blowing up for me:
Uncaught Error: Cannot find module 'react/lib/EventPluginHub'

Using:

"dependencies": { "babel-plugin-transform-class-properties": "^6.18.0", "material-ui": "^0.16.3", "meteor-node-stubs": "^0.2.4", "react": "^15.4.0", "react-addons-pure-render-mixin": "^15.4.0", "react-dom": "^15.4.0", "react-mounter": "^1.2.0", "react-tap-event-plugin": "^1.0.0" }

@stevewillard
Copy link
Contributor

You need to use the latest version of react-tap-event-plugin which relies on the correct internal library from react-dom instead of react

"react-tap-event-plugin": "^2.0.1"

@brendonlamb
Copy link

Derp thanks. Didn't even see that it updated too- makes perfect sense.

@rmaroun
Copy link

rmaroun commented Nov 18, 2016

@brendonlamb did it work for you after upgrading to React 15.4.0, react-dom 15.4.0, material-ui 0.16.4, react-tap-event-plugin 2.0.1? I am still having the issue, thanks for the help?

UPDATE: had to run npm install and all went fine (using the React Boiletplate). thanks all.

@brendonlamb
Copy link

Just for reference too- using the latest version of everything at this point:

"dependencies": { "babel-plugin-transform-class-properties": "^6.18.0", "material-ui": "^0.16.3", "meteor-node-stubs": "^0.2.4", "react": "^15.4.0", "react-addons-pure-render-mixin": "^15.4.0", "react-dom": "^15.4.0", "react-mounter": "^1.2.0", "react-tap-event-plugin": "^2.0.1" }

@radik909
Copy link

radik909 commented Dec 9, 2016

    "material-ui": "^0.16.4",
    "react": "^15.4.1",
    "react-dom": "^15.4.1",
    "react-tap-event-plugin": "^2.0.1

I use the above versions but still I get the error Uncaught Error: Cannot find module 'react-dom/lib/ReactPerf' from 'react/lib/ReactAddonsDOMDependencies.js'

How to fix this?

@enzolutions
Copy link

@radik909 what @brendonlamb did works for me

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 3, 2017

@stevewillard Answered the question, thanks!
#6057 is going to help too. I'm closing.

Thylossus added a commit to Thylossus/tud-movie-character-insights that referenced this issue Mar 14, 2017
Updated dependency because of issues with the lates react
version. See mui/material-ui#5396

Signed-off-by: Tobias Kahse <tobias.kahse@stud.tu-darmstadt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

No branches or pull requests

9 participants