[docs][material-ui][theme] Add documentation on migrating JSS's alternative, array-based syntax to syntax supported by Emotion #42053
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array-based syntax to syntax supported by Emotion
Netlify deploy previewBundle size report |
zannager
added
package: material-ui
ZeeshanTamboli
approved these changes
May 11, 2024
There was a problem hiding this comment.
@cjl750 Thanks for the pull request. It looks good to me! We need another review from @DiegoAndai to confirm whether we should consider documenting this, as it wasn't requested before and doesn't seem to be a common use case. However, I see no issue with documenting it.
ZeeshanTamboli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a section to the page on breaking style and theme changes in v5 about migrating the alternative, array-based syntax for space- and comma-separated values to string-based values necessary for use with Emotion.
Since everything under the heading "Migrate theme styleOverrides to Emotion" was about refactoring local rule references, I opted to take the content in that section and put it under a new sub-header (so the existing h3s became h4s), then I added a second sub-header for the new section about migrating the alternative, array-based syntax.
This is to resolve #41971