Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React Hook Form (uncontrolled forms) #32266

Open
2 tasks done
karranlemos opened this issue Apr 12, 2022 · 5 comments
Open
2 tasks done

Support for React Hook Form (uncontrolled forms) #32266

karranlemos opened this issue Apr 12, 2022 · 5 comments
Labels
new feature New feature or request

Comments

@karranlemos
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 馃挕

Support for React Hook Form, particularly for uncontrolled forms, which are really useful for improving performance, since components such as TextField can get really stuttery with both Formik and RHF controlled components.

Although we already can integrated TextField with uncontrolled RHF functions, but it creates some problems with its internal state, such as the label not shrinking / growing when the field is set programatically or dirty checks not working.

In the later thread, @oliviertassinari suggested reevaluating supporting RHF once it gained more traction, like Formik.

Since then, the library has exploded in popularity and, currently, has almost the same number of weekly downloads as Formik (1,780,630 x 1,903,062).

Are there any considerations on this matter?

Examples 馃寛

No response

Motivation 馃敠

No response

@karranlemos karranlemos added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 12, 2022
@danilo-leal danilo-leal added the new feature New feature or request label Apr 12, 2022
@siriwatknp
Copy link
Member

What do you expect to see by "Support for React Hook Form"? Do you mean the documentation about how-to integrate with React hook form?

@siriwatknp siriwatknp added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 27, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Since the issue is missing key information, and has been inactive for 7 days, it has been automatically closed.
If you wish to see the issue reopened, please provide the missing information.

@github-actions github-actions bot closed this as completed May 5, 2022
@karranlemos
Copy link
Author

@siriwatknp, I meant support for uncontrolled forms, which is the main feature provided by the library. Trying to use uncontrolled forms with Material UI can cause certain problems at the moment.

Since @oliviertassinari suggested that, once the library became more popular, you could reevaluate supporting this feature, and the library has become very popular as of late, I was thinking it might be a good time to bring up the matter.

@siriwatknp siriwatknp removed the status: waiting for author Issue with insufficient information label May 6, 2022
@siriwatknp
Copy link
Member

@karranlemos Thanks for the explanation. I have reopened the issue and wait for upvotes.

@siriwatknp siriwatknp reopened this May 6, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 17, 2022

Duplicate of #18269? I thought it could be solved with #18269 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants