Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoComplete] Component force sets html attribute autocomplete='off' #4639

Closed
mattmiddlesworth opened this issue Jul 7, 2016 · 3 comments
Closed
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!

Comments

@mattmiddlesworth
Copy link

Problem description

This should be allowed to be optionally set by a property just like a TextField

Steps to reproduce

return _react2.default.createElement(
        'div',
        { style: prepareStyles((0, _simpleAssign2.default)(styles.root, style)) },
        _react2.default.createElement(_TextField2.default, _extends({}, other, {
          ref: 'searchTextField',
          **autoComplete: 'on',**
          value: searchText,
          onChange: this.handleChange,
          onBlur: this.handleBlur,
          onFocus: this.handleFocus,
          onKeyDown: this.handleKeyDown,
          floatingLabelText: floatingLabelText,
          hintText: hintText,
          fullWidth: fullWidth,
          multiLine: false,
          errorStyle: errorStyle
        })),

Versions

  • Material-UI: 0.15.1
  • React: 15.1.0
  • Browser: Chrome 52.0.2743.60 beta-m (64-bit)
@mattmiddlesworth mattmiddlesworth changed the title Autocomplete force sets html attribute autocomplete='off' Autocomplete component force sets html attribute autocomplete='off' Jul 7, 2016
@johntran
Copy link

I use autocomplete as part of a form. This would be a useful feature. Easy fix. I can provide a PR.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari changed the title Autocomplete component force sets html attribute autocomplete='off' [AutoComplete] Component force sets html attribute autocomplete='off' Sep 18, 2016
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 18, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 18, 2016

I agree, I think that we should all users to override the autoComplete property.
Actually, I think that it's a more general issue where we spread the {...other} properties at the beginning and not at the end of the component. Hence, losing precedence.

@oliviertassinari
Copy link
Member

Closed by #4783

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants