Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Showcases - Layout changes when changing "Sort by" #15244

Closed
thomasnordquist opened this issue Apr 7, 2019 · 3 comments · Fixed by #15255
Closed

Docs: Showcases - Layout changes when changing "Sort by" #15244

thomasnordquist opened this issue Apr 7, 2019 · 3 comments · Fixed by #15255
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@thomasnordquist
Copy link
Contributor

thomasnordquist commented Apr 7, 2019 •
edited

https://next.material-ui.com/discover-more/showcase/

before after
Bildschirmfoto 2019-04-07 um 19 52 02 Bildschirmfoto 2019-04-07 um 19 52 10
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 7, 2019 •
edited

@thomasnordquist Thank you for reporting the issue, my screen was too small to reproduce it.
I'm proposing this fix:

--- a/docs/src/pages/discover-more/showcase/Showcase.js
+++ b/docs/src/pages/discover-more/showcase/Showcase.js
@@ -17,6 +17,7 @@ import appList from './appList';

 const styles = theme => ({
   root: {
+    flexGrow: 1,
     backgroundColor: theme.palette.background.default,
     // Hide the demo container padding
     margin: -theme.spacing(3),

Does it solve the problem for you? Do you want to submit a pull request? :)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. labels Apr 7, 2019
@joshwooding
Copy link
Member

That fix solved it for me. (I tested it in the browser)

thomasnordquist pushed a commit to thomasnordquist/material-ui that referenced this issue Apr 8, 2019
[Docs] Fix layout glitch when changing sort-by in showcases
dd93d27 
Fixes mui#15244
@thomasnordquist thomasnordquist mentioned this issue Apr 8, 2019
Merged
1 task
@thomasnordquist
Copy link
Contributor Author

@joshwooding thank you for testing.
I can confirm that the patch fixes the layout issue. I opened a PR (mentioned just above this comment).

oliviertassinari pushed a commit that referenced this issue Apr 8, 2019
@thomasnordquist @oliviertassinari
[docs] Fix layout glitch when changing sort-by in showcases (#15255)
f1249d5 
Fixes #15244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Fix layout glitch when changing sort-by in showcases thomasnordquist/material-ui
3 participants
@oliviertassinari @thomasnordquist @joshwooding