Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP integration #295

Open
sniffingsugar opened this issue Jan 3, 2022 · 4 comments
Open

LDAP integration #295

sniffingsugar opened this issue Jan 3, 2022 · 4 comments
Labels
effort:4 enhancement New feature or request prio c

Comments

@sniffingsugar
Copy link

Hihi all,

Maybe it would nice to add ldap or oauth2 support as login, we would love it.

This should be fairly easy to implement, ldap/sso is Standard in the Industry and would result in increase of user / maybe small companys.

@sniffingsugar
Copy link
Author

Addition to #94
Because it mentions oAuth only.

@muety
Copy link
Owner

muety commented Jan 3, 2022

Thanks for your feature request. Yes, LDAP is widely used and there is good tooling / libraries for it. It would still be quite some effort to implement LDAP login for Wakapi, though. I'm happy to do so, if people actually need it, but if it's rather a "nice-to-have" / "won't hurt" kind of feature, I'd rather leave it out.

Could you briefly describe your use case, how you would benefit from LDAP login? Are you using Wakapi in an organization? Or do you have your own, private LDAP-based user management?

Anyone else interested in this feature?

@muety muety added effort:4 enhancement New feature or request prio c labels Jan 3, 2022
@sniffingsugar
Copy link
Author

Hello @muety

thanks for your quick response 👍

We a small team (~5) of devs would love to see ldap support, we mostly use only software with integrated ldap support. (Own
OpenLDAP Server with Keycloak(oAuth/SAML).

The benefits are clear:

  • Keep users' account details updated
  • One login for all selfhosted services
  • Creation of internal dashboard based on LDAP groups

It is not just an "nice to have" feature. (more and more people switching to SSO/LDAP, just for the ease)
That's my point of view, maybe other people think the same way.

I would like to familiarize myself with your source code and would be happy to help if you need any help. In the form of a PR. :)

@muety
Copy link
Owner

muety commented Jan 3, 2022

Thanks for making me better understand your needs! Feature request accepted ✔️!

Contributions are welcome, so if you want to go about this, feel free. If so, I'd suggest you familiarize yourself a bit with the code base, think through your implementation and then briefly outline it here, so we can have a quick chat about it before actually writing code. Just to make sure we're on the same track.

Otherwise, I'll have a look myself, but don't expect it to happen too soon.

@muety muety changed the title [Feature Request] LDAP / oAuth support LDAP integration Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:4 enhancement New feature or request prio c
Projects
None yet
Development

No branches or pull requests

2 participants