Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Different color handling in normal and fullscreen mode #361

Closed
SammysHP opened this issue Apr 22, 2019 · 3 comments
Closed

Different color handling in normal and fullscreen mode #361

SammysHP opened this issue Apr 22, 2019 · 3 comments

Comments

@SammysHP
Copy link

SammysHP commented Apr 22, 2019

In normal window mode background defines the color of the background (and the text of the statusbar) while foreground controls the background color of the statusbar.

In fullscreen mode the background is black while the statusbar uses background as the background and foreground for the text.

Version 25.

@taimoorgit
Copy link

Seems like line 453 of window.c does this intentionally.
image

@SammysHP
Copy link
Author

Obviously two colors are not enough if there is a different interpretation of the colors. I would expect that a background color is always the background and the same for a foreground color. As the bar has a different color I think that at least three colors (bar fg, bar bg, image bg) are necessary (or just bg and fg while the bar is simply inverted). But different interpretation depending on fullscreen state doen't make sense for me.

@xyb3rt
Copy link
Owner

xyb3rt commented Jul 16, 2019

I'll get rid of the special bg handling for fullscreen mode as soon as I have the time to do so.

xyb3rt added a commit that referenced this issue Jul 16, 2019
@xyb3rt xyb3rt closed this as completed Jul 16, 2019
neg-serg pushed a commit to neg-serg/sxiv that referenced this issue Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants