Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Quote widget features (bugs?) #638

Open
ryanbuening opened this issue Feb 18, 2024 · 2 comments
Open

[Feature Request] Quote widget features (bugs?) #638

ryanbuening opened this issue Feb 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ryanbuening
Copy link

First off, great extension. 馃憤 I just started playing around with it in Firefox and noticed a couple of things with the Quote widget:

  1. If I uncheck Author link and Show author image in the settings, the UI still shows the empty container under the quote. Is this by design? I think it would be nice if that entire container was hidden if there is no author. (somewhat related to my PR here)

image

image

  1. Add option to update/change quote once a day instead of every time the new tab is loaded/refreshed. Sometimes is nice to focus on one quote during day rather than getting a new quote on every new tab.

Thanks again for a great extension!

@ryanbuening ryanbuening added the enhancement New feature or request label Feb 18, 2024
@davidcralph
Copy link
Member

Hi,

Thanks for supporting the extension.

The empty box is not intentional, this is a bug and we will look at it as soon as possible!

As for 2., this is a big maybe because as mentioned in #342, the code that would be used in this is incredibly broken at the moment.

@davidcralph
Copy link
Member

As per the referenced issue, I'm happy to let you know that 1. has been fixed and will ship in the next update 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants